Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-122237: Fix repl auto indentation wrong with comments #122383

Conversation

AnsonTrapani
Copy link

@AnsonTrapani AnsonTrapani commented Jul 29, 2024

Copy link

cpython-cla-bot bot commented Jul 29, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jul 29, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Eclips4 Eclips4 changed the title Fix repl auto indentation wrong with comments: gh-122237 gh-122237: Fix repl auto indentation wrong with comments Jul 29, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 29, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@devdanzin
Copy link
Contributor

There's also a proposed fix in #122238.

@AnsonTrapani
Copy link
Author

There's also a proposed fix in #122238.

Hi devdanzin,

Does that one get the priority then or is this merge request going to be closed without a merge? Sorry, this is my first time contributing here so I'm not sure of the procedure!

Thank you!

@terryjreedy
Copy link
Member

If two PRs have different solutions, 'priority' is not an issue. (I have not looked at either.) A core dev needs to decide which is superior and merge that, possibly after further changes. Reviewers can test both and give opinions.

@ambv
Copy link
Contributor

ambv commented Oct 23, 2024

Fixed in GH-123196.

@ambv ambv closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants